Thank you for this PR.
Merging manifest is a broad task and I believe we should not be limited to only <application>. I've started separate class called ManifestMerger.
Keep this PR open, I will try to make commit on top of this

I believe we should not be limited to only <application>. I've started separate class called ManifestMerger. Keep this PR open, I will try to make commit on top of this

Cool, I was about to suggest this but didn't seeing how busy you were :)

This'll be really useful :P

Please confirm :1544e4b

Please confirm :1544e4b

Hi, sorry for the delay (was afk due to health issues), unfortunately no, the resulting apk still has invalid manifest xml.

What is " invalid manifest xml" ?

What is " invalid manifest xml" ?

The same issue which I pointed out in our past conversations when the resulting apk wasn't recognised as a valid apk (REAndroid/APKEditor#214 (comment)):

the only issue is the resulting manifest is taken as invalid resulting in apk to be taken as invalid, but if we just open (with tools like MT) the manifest do nothing in it (basically no change) then save it back the apk&manifest becomes valid automatically (as their compiler fixes the elements), so most probably our merge method here is doing something strange which we need to invistigate.

which i was able to solve using json way of merging elements.

I couldn't get "invalid xml" message anywhere.

But i got Failure [INSTALL_PARSE_FAILED_MANIFEST_MALFORMED: Failed parse during installPackageLI: (at Binary XML file line #38): No value supplied for <android:name>] ,

fixed by: 1e9108a

Which application you're testing on ?

For now below are the results with different browsers on my end:

• UPX Browser [Error, issue still persists]
• Brave Browser [Error, issue still persists]
• Opera Browser [Fixed, No issues]

I couldn't get "invalid xml" message anywhere.

It's not invalid xml error, just what I said from my end where issue lies, If we specifically ask about error then we get There was a problem parsing the package error.

Awesome with dfca9f5 just now, It's fixed 🥳

• UPX Browser [Fixed, No issues]
• Brave Browser [Fixed, No issues]
• Opera Browser [Fixed, No issues]

• Use adb install file.apk, to get specific error messages.
• I am testing with sample provided here:merge issues with chromium based browsers APKEditor#214
• There is also latest commit: dfca9f5